Daniel Erez has posted comments on this change.

Change subject: rest: VirtIO-SCSI enabled flag
......................................................................


Patch Set 12:

(4 comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmResourceHelper.java
Line 1: package org.ovirt.engine.api.restapi.resource;
Line 2: 
Line 3: public class VmResourceHelper extends BackendResource {
Done
Line 4: 
Line 5:     private static VmResourceHelper instance;
Line 6: 
Line 7:     private VmResourceHelper() {


....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
Line 7: import java.util.List;
Line 8: 
Line 9: public class VmHelper extends ResourceHelper {
Line 10: 
Line 11:     private static VmHelper instance = new VmHelper();
Done
Line 12: 
Line 13:     private VmHelper() {
Line 14:     }
Line 15: 


Line 9: public class VmHelper extends ResourceHelper {
Line 10: 
Line 11:     private static VmHelper instance = new VmHelper();
Line 12: 
Line 13:     private VmHelper() {
Done
Line 14:     }
Line 15: 
Line 16:     public static VmHelper getInstance() {
Line 17:         return instance;


....................................................
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
Line 617:         resource.setValidatorLocator(validatorLocator);
Line 618:         resource.setSessionHelper(sessionHelper);
Line 619:         resource.setMessageBundle(messageBundle);
Line 620:         resource.setHttpHeaders(httpHeaders);
Line 621:     }
Removed the duplicate code from AbstractBackendResourceTest#initResource since 
'setMappingLocator' is applicable only for AbstractBackendResourceTest.


-- 
To view, visit http://gerrit.ovirt.org/19154
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I481025152b20579ac615d9023ed0cef9b64558e1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to