Allon Mureinik has posted comments on this change.
Change subject: rest: VirtIO-SCSI enabled flag
......................................................................
Patch Set 12: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
Line 7: import java.util.List;
Line 8:
Line 9: public class VmHelper extends ResourceHelper {
Line 10:
Line 11: private static VmHelper instance = new VmHelper();
should probably be final, while you're at it.
Line 12:
Line 13: private VmHelper() {
Line 14: }
Line 15:
Line 9: public class VmHelper extends ResourceHelper {
Line 10:
Line 11: private static VmHelper instance = new VmHelper();
Line 12:
Line 13: private VmHelper() {
I'd add a comment here, just to make IDEs happy.
Line 14: }
Line 15:
Line 16: public static VmHelper getInstance() {
Line 17: return instance;
--
To view, visit http://gerrit.ovirt.org/19154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I481025152b20579ac615d9023ed0cef9b64558e1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
