Arik Hadas has posted comments on this change. Change subject: engine: fix race in CommandAsyncTask ......................................................................
Patch Set 1: I wouldn't change the code in 3.3 if the problem can't be reproduced in 3.3. there are lots of places which are not thread-safe, take a look for example at AuditLogableBase#setVm and AuditLogableBase#getVm methods - they sure aren't thread safe which can lead to bugs in the future but by design we try to prevent concurrent calls to those methods so in practice there is no problem. I'm not sure if now that we're using command id we still need the locks there, if not a better solution will be to remove the locks. Anyway, if you still think the code should be changed, then the change looks good to me. -- To view, visit http://gerrit.ovirt.org/20183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id265df1c1843b976c6f8d65729fd6717c3df3c76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
