Tomas Jelinek has posted comments on this change. Change subject: engine: fix race in CommandAsyncTask ......................................................................
Patch Set 1: well, hardly can. And certainly not from two different commands like in the attached bug. But the fact that the _multiTasksByCommandIds is not locked correctly still apply so if some command would touch it from more threads it would be vulnerable. I don't say we are doing this - what I say is that it is incorrect and can cause surprises in the future. -- To view, visit http://gerrit.ovirt.org/20183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id265df1c1843b976c6f8d65729fd6717c3df3c76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
