Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Control refresh behavior (#802378) ......................................................................
webadmin: Control refresh behavior (#802378) https://bugzilla.redhat.com/802378 This patch modifies the data grid auto-refresh behavior in the following way: - when the application window loses focus, the auto-refresh interval for each grid is set to 60 seconds (previously, auto-refresh timer was simply stopped) - when the application window gains focus, the auto-refresh interval for each grid is restored to its original value (previously, auto-refresh timer was simply resumed) Relevant focus handling logic was moved to AbstractRefreshManager. Added 60-second refresh interval to refresh interval options for all data grids. GridController's toForeground() and toBackground() methods were removed since they're not needed anymore (their implementation stopped/resumed the UiCommon model's refresh timer). This patch also does some cleanup regarding login logic shared by both applications: - AbstractLoginPopupPresenterWidget prevents common code duplication - LoginModel fixes to eliminate TODO/FIXME application code: - LoginCommand is the "default" command - LoginCommand is added to LoginModel's command list - upon failed login, corresponding EntityModels (userName, password, domain) and LoginCommand are re-enabled again Change-Id: I08c6dd9fe2c63d58b7a2d865552564d7e73425c2 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseClientGinjector.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridController.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/ConnectAutomaticallyProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalDataBoundModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 16 files changed, 199 insertions(+), 244 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08c6dd9fe2c63d58b7a2d865552564d7e73425c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
