Daniel Erez has posted comments on this change. Change subject: webadmin: Display default vNIC profile in tab ......................................................................
Patch Set 3: Code-Review+2 (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java Line 165: customPropertiesSupported = Line 166: (Boolean) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.SupportCustomDeviceProperties, Line 167: dcCompatibilityVersion.toString()); Line 168: Line 169: getPortMirroring().setIsChangable(isPortMirroringSupported()); I think it's usually cleaner/clearer to separate to responsibility of setting the values and perform action based on these values. Probably more crucial in larger functions (matter of taste I guess). Line 170: initCustomPropertySheet(); Line 171: initNetworkQoSList(qosId); Line 172: } Line 173: -- To view, visit http://gerrit.ovirt.org/19901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
