Daniel Erez has posted comments on this change.
Change subject: webadmin: Display default vNIC profile in tab
......................................................................
Patch Set 3:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
Line 118: List<VnicProfileModel> profiles = new
LinkedList<VnicProfileModel>();
Line 119: profiles.add(createDefaultProfile());
Line 120: getProfiles().setItems(profiles);
Line 121: } else {
Line 122: // not first run (user picked different DC), want to keep
existing entries and update DC-related properties
do we invoke 'initProfiles' on DC SelectedItemChangedEvent?
Line 123: for (VnicProfileModel profile : existingProfiles) {
Line 124:
profile.updateDc(getSelectedDc().getcompatibility_version(), false,
getSelectedDc().getId(), null);
Line 125: }
Line 126: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
Line 165: customPropertiesSupported =
Line 166: (Boolean)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.SupportCustomDeviceProperties,
Line 167: dcCompatibilityVersion.toString());
Line 168:
Line 169: getPortMirroring().setIsChangable(isPortMirroringSupported());
consider refactoring to two methods (e.g. updateDC and on/post-UpdateDC)
Line 170: initCustomPropertySheet();
Line 171: initNetworkQoSList(qosId);
Line 172: }
Line 173:
Line 171: initNetworkQoSList(qosId);
Line 172: }
Line 173:
Line 174: protected boolean isPortMirroringSupported() {
Line 175: Version v31 = new Version(3, 1);
not related to the patch - but you should use Version.v3_1 instead
Line 176: boolean isLessThan31 =
getDcCompatibilityVersion().compareTo(v31) < 0;
Line 177:
Line 178: return !isLessThan31;
Line 179: }
--
To view, visit http://gerrit.ovirt.org/19901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
