Noam Slomianko has uploaded a new change for review.
Change subject: engine: external scheduler dont pass empty guid
......................................................................
engine: external scheduler dont pass empty guid
When using external balance an empty string may return resulting
in a 0000-00... guid, causing unnecessary logging of missing guid
Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e
Signed-off-by: Noam Slomianko <nslom...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/20034/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
index 90db4e7..f7433a4 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
@@ -226,7 +226,11 @@
}
Pair<List<Guid>, Guid> retValue = new Pair<List<Guid>, Guid>();
retValue.setFirst(hostIDs);
- retValue.setSecond(new Guid(castedResult[0].toString()));
+ if (castedResult[0].toString().isEmpty()) {
+ return null;
+ } else {
+ retValue.setSecond(new Guid(castedResult[0].toString()));
+ }
return retValue;
}
--
To view, visit http://gerrit.ovirt.org/20034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
