Ravi Nori has posted comments on this change.
Change subject: core: Change LDAP identifer to ExternalId
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
Line 107: ownerId = user.getId();
Line 108: }
Line 109: }
Line 110: if (ownerId == null) {
Line 111: if (group != null) {
Can be moved to if block above
Line 112: ownerId = group.getId();
Line 113: }
Line 114: }
Line 115:
--
To view, visit http://gerrit.ovirt.org/19482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib464dfc2353158fccc92922893614a35b5c06081
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
