Lior Vernia has posted comments on this change.

Change subject: webadmin: Hide profiles tab if network is non-VM
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
Line 42:                 }
Line 43:             }
Line 44:         });
Line 45: 
Line 46:         getView().toggleProfilesVisibility((Boolean) 
model.getIsVmNetwork().getEntity());
Good to know though that the convention would be to set values after 
setWindow() is called, will conform in the future.
Line 47:         model.getIsVmNetwork().getEntityChangedEvent().addListener(new 
IEventListener() {
Line 48: 
Line 49:             @Override
Line 50:             public void eventRaised(Event ev, Object sender, EventArgs 
args) {


-- 
To view, visit http://gerrit.ovirt.org/19900
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to