Daniel Erez has posted comments on this change.
Change subject: webadmin: Hide profiles tab if network is non-VM
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
Line 42: }
Line 43: }
Line 44: });
Line 45:
Line 46: getView().toggleProfilesVisibility((Boolean)
model.getIsVmNetwork().getEntity());
We usually try to set entity's value after adding a listener (to avoid
duplication of the callback code). But, in this case, it will require setting
the entity of model.getIsVmNetwork() after setWindow. I.e. moving from the
model's ctr to an init method. So, probably not worth the effort after all...
Line 47: model.getIsVmNetwork().getEntityChangedEvent().addListener(new
IEventListener() {
Line 48:
Line 49: @Override
Line 50: public void eventRaised(Event ev, Object sender, EventArgs
args) {
--
To view, visit http://gerrit.ovirt.org/19900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
