Alex Lourie has posted comments on this change.

Change subject: packaging: setup: run readonly user creation with non-empty user
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/common_utils.py
Line 607:         user is None or
Line 608:         user is ''
Line 609:     ):
Line 610:         raise RuntimeError('Empty username provided!')
Line 611: 
indeed. This code is a precaution so that if empty value still gets in somehow, 
it won't work.
Line 612:     # Check whether we can create DB:
Line 613:     global DB_ADMIN
Line 614:     canCreateDb = False
Line 615:     errorMsg = None


-- 
To view, visit http://gerrit.ovirt.org/19747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0478d8adb098f0c6e7999b16f75ee68377a6665a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to