Yaniv Dary has posted comments on this change.

Change subject: packaging: setup: run readonly user creation with non-empty user
......................................................................


Patch Set 2: -Code-Review

(1 comment)

....................................................
File packaging/ovirt-engine-dwh-setup.py
Line 366:                     else:
Line 367:                         readonly_user = utils.askQuestion(
Line 368:                             question='Provide a username for 
read-only user'
Line 369:                         )
Line 370:                         readonly_pass = getpass.getpass(
Why are we using this getpass and not the function we already use that does 
verify and alerts on weak password?
Line 371:                             prompt='Provide a password for read-only 
user: '
Line 372:                         )
Line 373:                         readonly_secure = utils.askYesNo(
Line 374:                             question=(


-- 
To view, visit http://gerrit.ovirt.org/19747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0478d8adb098f0c6e7999b16f75ee68377a6665a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to