Shubhendu Tripathi has posted comments on this change.

Change subject: engine:Add dao method to update task on brick
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

One minor comment

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java
Line 45:      */
Line 46:     public void updateBrickTaskByHostIdBrickDir(Guid serverId, String 
brickDir, Guid taskId);
Line 47: 
Line 48:     /**
Line 49:      * Updates the task id populated in brick entity in a batch.
Comments look like they are about a single brick. 
May be comments can say that it updates details for multiple bricks
Line 50:      * The brick is identified by server id and brick dir populated in 
the brick entity
Line 51:      * @param bricks
Line 52:      */
Line 53:     public void 
updateAllBrickTasksByHostIdBrickDirInBatch(Collection<GlusterBrickEntity> 
bricks);


-- 
To view, visit http://gerrit.ovirt.org/19615
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3abd6d4a3649a8c4880e2fdbde190ab1d2268c06
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to