Sahina Bose has posted comments on this change.

Change subject: engine:Add dao method to update task on brick
......................................................................


Patch Set 2:

(3 comments)

....................................................
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java
Line 200:         GlusterBrickEntity existingBrick2 = 
dao.getById(FixturesTool.GLUSTER_BRICK_UUID2);
Line 201:         GlusterAsyncTask asyncTask = new GlusterAsyncTask();
Line 202:         asyncTask.setTaskId(FixturesTool.GLUSTER_ASYNC_TASK_ID1);
Line 203: 
Line 204:         //assertNull(existingBrick.getAsyncTask());
Done
Line 205: 
Line 206:         GlusterBrickEntity updateBrick = new GlusterBrickEntity();
Line 207:         
updateBrick.setBrickDirectory(existingBrick.getBrickDirectory());
Line 208:         updateBrick.setServerId(existingBrick.getServerId());


Line 217:         bricks.add(updateBrick);
Line 218:         bricks.add(updateBrick2);
Line 219: 
Line 220: 
Line 221:         dao.updateAllBrickTasksByHostIdBrickDir(bricks);
Will rename to indicate it is batch
Line 222: 
Line 223:         GlusterBrickEntity newEntity1 = 
dao.getById(FixturesTool.GLUSTER_BRICK_UUID1);
Line 224:         GlusterBrickEntity newEntity2 = 
dao.getById(FixturesTool.GLUSTER_BRICK_UUID1);
Line 225: 


....................................................
File packaging/dbscripts/gluster_volumes_sp.sql
Line 464: END; $procedure$
Line 465: LANGUAGE plpgsql;
Line 466: 
Line 467: Create or replace FUNCTION 
UpdateGlusterBrickTaskByServerIdBrickDir(v_server_id UUID,
Line 468:                                                                       
                                                             v_brick_dir 
VARCHAR(200),
Done
Line 469:                                                                       
                                                                 v_task_id UUID)
Line 470:     RETURNS VOID
Line 471:     AS $procedure$
Line 472: BEGIN


-- 
To view, visit http://gerrit.ovirt.org/19615
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3abd6d4a3649a8c4880e2fdbde190ab1d2268c06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to