Nir Soffer has posted comments on this change. Change subject: engine: Illegal images should be skipped when validating duplicates ......................................................................
Patch Set 5: (1 comment) Questions about the purpose of this patch. .................................................... Commit Message Line 11: exists its probably would be better to clone VM instead of import, just Line 12: to prevent potential data loss. Engine assumes that its database Line 13: correctly represents the storage so this validation is done against Line 14: database values. The problem is that currently Engine takes in Line 15: consideration also ILLEGAL images although they are illegal. Looking at the patch, it seems that it does more then skip illegal disk images, as promised in this message. Is this really the minimal patch needed or there are other unrelated changes that snicked in? Line 16: Line 17: Change-Id: I7b43e4b4e8e04dfb644a33ea9ce2a474987c5e3c -- To view, visit http://gerrit.ovirt.org/19246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b43e4b4e8e04dfb644a33ea9ce2a474987c5e3c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
