Maor Lipchuk has posted comments on this change.
Change subject: engine: Illegal images should be skipped when validating
duplicates
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 369: protected boolean validateNoDuplicateDiskImages(List<DiskImage>
diskImages) {
Line 370: List<String> existingLegalDisksAliases = new
ArrayList<String>();
Line 371: List<DiskImage> disksFromDB =
ImagesHandler.getDisksFromDB(diskImages);
Line 372:
Line 373: if (disksFromDB.isEmpty()) {
Not sure that I'm following.
the question is whether the set of the ForceOverride to true is relevant only
in case when there are illegal disks related to the VM/Tempalte, what will
happen if we will use set force override to true if there not any disks in the
DB.
Actually, we already use force override = true on the other disks, since in the
scenario that we have only one illegal disk among many others, the
forceOverride parameter set to true, and this parameter is global (in the
parameters) so all other VM disks operations will use it when calling
CopyImageGroup.
Line 374: return true;
Line 375: }
Line 376:
Line 377: for (DiskImage disk : disksFromDB) {
--
To view, visit http://gerrit.ovirt.org/19246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b43e4b4e8e04dfb644a33ea9ce2a474987c5e3c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
