Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: stop and notify if setup is not run as root
......................................................................
Patch Set 1:
(2 comments)
....................................................
File packaging/ovirt-engine-dwh-setup.py
Line 62: ERR_DB_CREATE_FAILED = "Error while trying to create %s db" % DB_NAME
Line 63:
Line 64: log_file = utils.initLogging("%s-setup" % DWH_PACKAGE_NAME,
"/var/log/ovirt-engine")
Line 65:
Line 66: def _verifyUserPermissions():
_ means it's a private function. if you do an import * this function will not
be imported.
Line 67: username = pwd.getpwuid(os.getuid())[0]
Line 68: if os.geteuid() != 0:
Line 69: sys.exit(
Line 70: 'Error: insufficient permissions for user {user}, '
Line 70: 'Error: insufficient permissions for user {user}, '
Line 71: 'you must run with user root.'.format(
Line 72: user=username
Line 73: )
Line 74: )
don't you want to log it?
Line 75:
Line 76: def dbExists(db_dict):
Line 77: logging.debug("checking if %s db already exists" % db_dict["name"])
Line 78: (output, rc) = utils.execSqlCmd(
--
To view, visit http://gerrit.ovirt.org/18753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
