Yaniv Dary has posted comments on this change.

Change subject: packaging: setup: stop and notify if setup is not run as root
......................................................................


Patch Set 1:

(1 comment)

....................................................
File packaging/ovirt-engine-dwh-setup.py
Line 62: ERR_DB_CREATE_FAILED = "Error while trying to create %s db" % DB_NAME
Line 63: 
Line 64: log_file = utils.initLogging("%s-setup" % DWH_PACKAGE_NAME, 
"/var/log/ovirt-engine")
Line 65: 
Line 66: def _verifyUserPermissions():
why start with '_'?
Line 67:     username = pwd.getpwuid(os.getuid())[0]
Line 68:     if os.geteuid() != 0:
Line 69:         sys.exit(
Line 70:             'Error: insufficient permissions for user {user}, '


-- 
To view, visit http://gerrit.ovirt.org/18753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to