Michael Kublin has posted comments on this change.
Change subject: core: add hotplug support when adding VM nic
......................................................................
Patch Set 5: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 80:
whitespace
Line 81: boolean succeded = true;
you has getVM().getDynamic() no need for qury
Line 103: VmStatic vm =
DbFacade.getInstance().getVmStaticDAO().get(getParameters().getVmId());
please use getVm(), I know not your code
Line 108:
whitespace
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
Line 127
why removed comment?
Line 131: HotUnplugNic("org.ovirt.engine.core.vdsbroker.vdsbroker");
please put HotPlugNic and HotUnPlugNic under or above HotPlugDisk
--
To view, visit http://gerrit.ovirt.org/3453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64adbc2ab0f30a3ba532ddd8cc5986528b4b079b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
