Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: revert nfs config on cleanup ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/ovirt_engine_setup/util.py Line 44: ^ Line 45: \s* Line 46: (?P<param>\w+) Line 47: \s* Line 48: = I think that this function should be generic enough to handle most cases. 1. keep indentation or not. 2. separator, may be none per ssh_config for example. 3. there is always the question of were to add the new lines... for example adding these at end of file is incompatible with ssh format or ssl.conf, I think of 'below=' or 'after='... Line 49: \s* Line 50: .* Line 51: $ Line 52: """ -- To view, visit http://gerrit.ovirt.org/19001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
