Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: revert nfs config on cleanup ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/ovirt_engine_setup/util.py Line 52: """ Line 53: ) Line 54: Line 55: Line 56: def editConfigContent(content, params, changed_lines=[]): OK, _now_ I understood :-) Further explanations, for whoever reads this in the future, are e.g. in the paragraph starting with "Default parameter values are evaluated when the function definition is executed", in http://docs.python.org/release/2.7.5/reference/compound_stmts.html#function-definitions Thanks! Line 57: newcontent = [] Line 58: for line in content: Line 59: f = _RE_PARAM.match(line) Line 60: if f is not None and f.group('param') in params: -- To view, visit http://gerrit.ovirt.org/19001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
