Allon Mureinik has posted comments on this change.
Change subject: core: Fix exception handling
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
Line 221: }
Line 222:
Line 223: private void handleMappingException(Object value, Exception ex) {
Line 224: log.error("Can't map Enum type " + value + "Exception is: " +
ex.getMessage());
Line 225: log.debug("", ex);
If you only call this method in one place, it's kind of pointless to have it as
a method - just inline these two lines in the catch block.
Line 226: }
Line 227:
Line 228: private static class ProcData {
Line 229: private String colName;
--
To view, visit http://gerrit.ovirt.org/19352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I455378d79e2ee2232f96dc18c10b010f954ca3be
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
