Allon Mureinik has posted comments on this change.
Change subject: core: Fix exception handling
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
Line 190: handleMappingException(value, ex);
Line 191:
Line 192: } catch (IllegalAccessException ex) {
Line 193: handleMappingException(value, ex);
Line 194: }
We are in Java 7, no point in duplicating this code.
try {
...
} catch (NoSuchMethodException | InvocationTargetException |
IllegalAccessException ex) {
log.error("Can't map Enum type " + value + "Exception is: " +
ex.getMessage());
log.debug("", ex);
}
Line 195: }
Line 196:
Line 197: if (value instanceof Guid) {
Line 198: value = value.toString();
--
To view, visit http://gerrit.ovirt.org/19352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I455378d79e2ee2232f96dc18c10b010f954ca3be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
