Kanagaraj M has posted comments on this change.
Change subject: webadmin: Moved transport Type Column of Volume to the General
Sub Tab under Volumes
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
minor comments,
Rebase and verify
....................................................
Commit Message
Line 3: AuthorDate: 2013-09-21 14:05:18 +0530
Line 4: Commit: Anmol Babu <anb...@redhat.com>
Line 5: CommitDate: 2013-09-28 00:46:15 +0530
Line 6:
Line 7: webadmin: Moved transport Type Column of Volume to the General Sub Tab
under Volumes
reduce the length of the commit header, may be something like
"Volume transport-type column moved to general tab"
Line 8:
Line 9: Moved transport Type Column of Volume to the General Sub Tab under
Volumes
Line 10:
Line 11: Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java
Line 16: }
Line 17:
Line 18: @Override
Line 19: public String render(Set<TransportType> transportTypes) {
Line 20: // TODO Auto-generated method stub
Remove the TODO
Line 21: Translator transportTypeTranslator =
EnumTranslator.Create(TransportType.class);
Line 22: StringBuilder transportTypesBuilder = new StringBuilder();
Line 23: Iterator<TransportType> iterator = transportTypes.iterator();
Line 24: while (iterator.hasNext())
--
To view, visit http://gerrit.ovirt.org/19423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
