Kanagaraj M has posted comments on this change.

Change subject: webadmin: Moved transport Type Column of Volume to the General 
Sub Tab under Volumes Moved transport Type Column of Volume to the General Sub 
Tab under Volumes
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java
Line 140:             {
Line 141:                 transportTypesBuilder.append(", "); //$NON-NLS-1$
Line 142:             }
Line 143:         }
Line 144:         this.transportTypes = new 
String(transportTypesBuilder.toString());
Consider moving this translation to the View itself.

You could refer to ClusterTypeLabel, if you want to know how to write a custom 
renderer which would do the translation
Line 145:     }
Line 146: 


-- 
To view, visit http://gerrit.ovirt.org/19423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to