Sandro Bonazzola has posted comments on this change. Change subject: packaging: support modifying java module path ......................................................................
Patch Set 2: Code-Review+1 The code looks good to me. However, I'm not sure about possible implications in shadowing product modules. I would prefer that someone else take a look at this before approving. -- To view, visit http://gerrit.ovirt.org/19586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda53f67fa801cf4eb00b11483e9a6ab712d4d74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
