Sandro Bonazzola has posted comments on this change.
Change subject: packaging: support modifying java module path
......................................................................
Patch Set 1:
(1 comment)
Just a minor comment inline
....................................................
File packaging/services/ovirt-engine/ovirt-engine.py
Line 60: """
Line 61: Link all the JBoss modules into a temporary directory.
Line 62: This required because jboss tries to automatically update
Line 63: indexes based on timestamp even if there is no permission
to do so.
Line 64: """
Shouldn't this be
"""
doc
"""
instead of
"
doc
"
Line 65:
Line 66: modifiedModulePath = []
Line 67: for index, element in enumerate(modulePath.split(':')):
Line 68: modulesTmpDir = os.path.join(
--
To view, visit http://gerrit.ovirt.org/19586
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibda53f67fa801cf4eb00b11483e9a6ab712d4d74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
