Lior Vernia has posted comments on this change.
Change subject: webadmin: Vnic hotplug validation - Patch 2 of 2
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
Line 270: @DefaultMessage("Changing the URL of this provider might hurt the
proper functioning of the following entities provided by it.\n\n{0}")
Line 271: String providerUrlWarningText(String providedEntities);
Line 272:
Line 273: // Vnic
Line 274: @DefaultMessage("NIC Hot Plug is not supported on cluster version
{0}, or the VM is running and does not support hot plug.")
I think a better wording would be "The VM is not down, and NIC Hot Plug is not
supported on cluster version {0}".
Line 275: String nicHotPlugNotSupported(String clusterVersion);
Line 276:
Line 277: @DefaultMessage("Updating 'profile' on a running virtual machine
while the NIC is plugged is not supported on cluster version {0}")
Line 278: String hotProfileUpdateNotSupported(String clusterVersion);
--
To view, visit http://gerrit.ovirt.org/19189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2434386f98c31a8d0fe44011ecadecb732ded19a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
