Lior Vernia has posted comments on this change.
Change subject: webadmin: Vnic hotplug validation - Patch 2 of 2
......................................................................
Patch Set 5: -Code-Review
(3 comments)
Actually, a couple more comments concerning the explanation to why hotplugging
is disabled, which I overlooked in the first review.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java
Line 71: initProfiles();
Line 72:
Line 73: // Plug should be the last one updated, cause it controls the
changeability of the other editor
Line 74: getPlugged().setEntity(getNic().isPlugged());
Line 75: if (!hotPlugSupported) {
Maybe change this to allowPlug() as well?
Line 76:
getPlugged().setChangeProhibitionReason(ConstantsManager.getInstance()
Line 77: .getMessages()
Line 78:
.hotPlugNotSupported(getClusterCompatibilityVersion().toString()));
Line 79: }
Line 74: getPlugged().setEntity(getNic().isPlugged());
Line 75: if (!hotPlugSupported) {
Line 76:
getPlugged().setChangeProhibitionReason(ConstantsManager.getInstance()
Line 77: .getMessages()
Line 78:
.hotPlugNotSupported(getClusterCompatibilityVersion().toString()));
And update the message? To explain that the NIC can't be plugged because the
cluster version isn't compatible AND because the VM is running.
Line 79: }
Line 80: getPlugged().setIsChangable(allowHotPlug());
Line 81:
Line 82: initCommands();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java
Line 68: initSelectedType();
Line 69:
getName().setEntity(AsyncDataProvider.getNewNicName(getVmNicList()));
Line 70: initMAC();
Line 71:
Line 72: if (!hotPlugSupported) {
Same comment as in EditVmInterfaceModel.
Line 73:
getPlugged().setChangeProhibitionReason(ConstantsManager.getInstance()
Line 74: .getMessages()
Line 75:
.hotPlugNotSupported(getClusterCompatibilityVersion().toString()));
Line 76: }
--
To view, visit http://gerrit.ovirt.org/19189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2434386f98c31a8d0fe44011ecadecb732ded19a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
