Maor Lipchuk has posted comments on this change.
Change subject: engine: Split update of 'isPlugged' and 'bootOrder'
properties...
......................................................................
Patch Set 7:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 112
Line 113
Line 114
Line 115
Line 116
right, my bad
Line 143: return disk.getDiskAlias();
Line 144: }
Line 145:
Line 146: public Disk getDisk() {
Line 147: if (disk == null) {
Hate when tests dictate our way of implementation...
You can simply use this method once at the beginning of the CDA as follow
disk = getDisk();
and don't use it anymore, I would even consider to remove the null check and
simply fetch the disk from the DB (this should not have much impact on our
performence). but this is simply implementation detail, so what ever you think.
Also please change the method to protected
Line 148: disk = getDiskDao().get(getParameters().getDiskId());
Line 149: }
Line 150: return disk;
Line 151: }
--
To view, visit http://gerrit.ovirt.org/19311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
