Allon Mureinik has posted comments on this change.
Change subject: engine: Split update of 'isPlugged' and 'bootOrder'
properties...
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Please add the missing annotation and make sure the test passes.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 76: }
Line 77:
Line 78: oldVmDevice = getVmDeviceDao().get(new
VmDeviceId(getDisk().getId(), getVmId()));
Line 79: if (getPlugAction() == VDSCommandType.HotPlugDisk &&
oldVmDevice.getIsPlugged()) {
Line 80: return
failCanDoAction(VdcBllMessages.HOT_PLUG_DISK_IS_NOT_UNPLUGGED);
there are two whitespaces between retrurn and failCanDoAction - please remove
one.
Line 81: }
Line 82:
Line 83: if (getPlugAction() == VDSCommandType.HotUnPlugDisk &&
!oldVmDevice.getIsPlugged()) {
Line 84: return
failCanDoAction(VdcBllMessages.HOT_UNPLUG_DISK_IS_NOT_PLUGGED);
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
Line 188: dao.updateHotPlugDisk(vmDevice);
Line 189: dao.get(getExistingEntityId());
Line 190: assertEquals(vmDevice.getIsPlugged(), newPluggedValue);
Line 191: }
Line 192:
should have @Test annotation
Line 193: public void testUpdateBootOrder() {
Line 194: VmDevice vmDevice = dao.get(getExistingEntityId());
Line 195: int newBootOrderValue = vmDevice.getBootOrder() + 1;
Line 196:
Assert.assertTrue(StringUtils.isNotBlank(vmDevice.getAddress()));
--
To view, visit http://gerrit.ovirt.org/19311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
