Lior Vernia has posted comments on this change.
Change subject: frontend: Select an empty profile does not work
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 383: // Save changes.
Line 384: nic.setName((String) getName().getEntity());
Line 385: VnicProfileView profile = (VnicProfileView)
getProfile().getSelectedItem();
Line 386: nic.setVnicProfileId(profile != null ? profile.getId() :
null);
Line 387: nic.setNetworkName(profile != null ? profile.getNetworkName()
: null);
I actually have a suggestion which might be better than adding this line
everywhere. Maybe add a method VmNetworkInterface.assignProfile(VnicProfile)
that both sets the profile ID and the network name (and maybe other fields that
are common to VmNetworkInterface and VnicProfile), and flag setVnicProfileId as
deprecated?
It is much more object-oriented to have VmNetworkInterface take care of itself,
and much less prone to errors from developers who wouldn't know that it's
required to set both the profile ID and the network name (which is difficult to
guess, as the existence of this bug implies).
Line 388: nic.setLinked((Boolean) getLinked().getEntity());
Line 389: if (getNicType().getSelectedItem() == null)
Line 390: {
Line 391: nic.setType(null);
--
To view, visit http://gerrit.ovirt.org/18791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
