Daniel Erez has posted comments on this change.
Change subject: frontend: Select an empty profile does not work
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 383: // Save changes.
Line 384: nic.setName((String) getName().getEntity());
Line 385: VnicProfileView profile = (VnicProfileView)
getProfile().getSelectedItem();
Line 386: nic.setVnicProfileId(profile != null ? profile.getId() :
null);
Line 387: nic.setNetworkName(profile != null ? profile.getNetworkName()
: null);
> The convention of having business entities not be programmed in an
> object-oriented manner doesn't sound like a good convention to me. But as you
> wish.
There is a reason behind keeping the business entities simple. These entities
are used by both client and server, which means they are being serialized using
gwt-rpc serialization process. Having said that, we should keep in mind that
this process is not perfect and has its limitations and issues. Furthermore,
such issues frequently occur only in web-mode (i.e. won't affect debug-mode) -
meaning, not easy/fun to resolve... Now, I certainly don't say that adding a
new method that gathers a few calls is too risky or wrong; I'm just saying that
I prefer to introduce such changes separately (at least in a context of a
re-factor patch rather than a crucial bug). Even just for sake of easier revert
when looking for the problem...
Line 388: nic.setLinked((Boolean) getLinked().getEntity());
Line 389: if (getNicType().getSelectedItem() == null)
Line 390: {
Line 391: nic.setType(null);
--
To view, visit http://gerrit.ovirt.org/18791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
