Sandro Bonazzola has posted comments on this change. Change subject: build: post ovirt-hosted-engine-setup-1.0 branching ......................................................................
Patch Set 2: Code-Review-1 (3 comments) .................................................... File configure.ac Line 18: dnl Line 19: AC_PREREQ(2.60) Line 20: Line 21: define([VERSION_MAJOR], [1]) Line 22: define([VERSION_MINOR], [0]) Done Line 23: define([VERSION_FIX], [0]) Line 24: define([VERSION_NUMBER], VERSION_MAJOR[.]VERSION_MINOR[.]VERSION_FIX) Line 25: define([VERSION_SUFFIX], [_master]) Line 26: Line 25: define([VERSION_SUFFIX], [_master]) Line 26: Line 27: AC_INIT([ovirt-hosted-engine-setup], VERSION_NUMBER[]VERSION_SUFFIX) Line 28: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 29: PACKAGE_RPM_RELEASE="0.0.$(echo VERSION_SUFFIX | sed 's/^_//')" it will be pulled in by version bump to 1.1.0 Line 30: PACKAGE_MAVEN_VERSION="VERSION_MAJOR.VERSION_MINOR.0$(echo VERSION_SUFFIX | sed 's/^_/-/')" Line 31: AC_SUBST([PACKAGE_RPM_VERSION]) Line 32: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 33: AC_SUBST([PACKAGE_MAVEN_VERSION]) .................................................... File ovirt-hosted-engine-setup.spec.in Line 92: %{vdsmhooksdir}/before_vm_start/ Line 93: Line 94: %changelog Line 95: * Tue Sep 17 2013 Sandro Bonazzola <sbona...@redhat.com> - 1.0.0-0.0.master Line 96: - Nightly Needed by rpmlint test for rpm sanity. The lines will be removed on next build. Line 97: Line 98: * Fri Sep 13 2013 Sandro Bonazzola <sbona...@redhat.com> - 1.0.0-0.4.beta Line 99: - 1.0.0-0.4.beta Line 100: - Resolves: BZ#1005767 -- To view, visit http://gerrit.ovirt.org/19307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I922f3a9e44a561d85a78d9d9612611d595cd1122 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches