Allon Mureinik has posted comments on this change.
Change subject: core: Clean up VmPoolDAO and its test
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
Line 22: * {@link org.ovirt.engine.core.dal.dbbroker.DbFacad}.
bug - will upload a new patchset.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmPoolDAOTest.java
Line 156
The DAO calls a stored procedure that does not a cannot work, since the
underlying table has been removed.
I real solution is to remove it, but that my take some amount of work - not
because it would break functionality, but because of the amount of sifting
through dead code that's required.
let's leave that to another patch?
--
To view, visit http://gerrit.ovirt.org/3525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08d8e317e6ef9a2c7e469e8ccc6792af99204c70
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
