Ravi Nori has posted comments on this change.
Change subject: core: LocalAdminPassword exception after engine restart
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
Line 218: @Override
Line 219: public <T> T getValue(ConfigValues name, String version) {
Line 220: T returnValue;
Line 221: Map<String, Object> values = null;
Line 222: if ((values = _vdcOptionCache.get(name.toString())) != null
&& (values.containsKey(version) || values.containsKey("general"))) {
Hi Omer the call is coming from
org.ovirt.engine.ui.uicommonweb.models.LoginModule
protected void raiseLoggedInEvent() {
// Cache all configurations values before logging-in
AsyncDataProvider.initCache(this);
}
So all config values are cached before logging-in, if a passwd field that is
encrypted is available only for version "general", the bad padding exception
will be thrown.
So we need a way to filter out all password fields from the map that is
returned to the get all config values query from the webadmin or we need some
logic in the backend to handle the unavailability of a value for versions other
than general.
How do we handle this situation?
Line 223: returnValue = (T) values.get(version);
Line 224: } else {
Line 225: VdcOption option = new VdcOption();
Line 226: option.setoption_name(name.toString());
--
To view, visit http://gerrit.ovirt.org/18065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
