Daniel Erez has posted comments on this change.
Change subject: frontend: display correct format in edit domain
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
Line 674: }
Line 675: }
Line 676:
Line 677: getFormat().setItems(formats);
Line 678: getFormat().setSelectedItem(getStorage() != null ?
getStorage().getStorageFormat() : selectItem);
ok, the reason it works is that setSelectItem won't fail if the item doesn't
actually exist. E.g. if items contains only V1 and setSelectedItem(V2) is
called, then getSelectedItem() will return V2. Of course it's a workaround,
which is another incentive to refactor this section to new vs edit...
Line 679: }
Line 680:
Line 681: private void updateItemsAvailability()
Line 682: {
--
To view, visit http://gerrit.ovirt.org/19187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0432d633fabcf62b14b267b8dd9ca517b69c029a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
