Sergey Gotliv has posted comments on this change. Change subject: provider: glance images listing size and limits ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java Line 238: Line 239: for (Image glanceImage : images) { Line 240: RepoImage repoImage = imageToRepoImage(glanceImage); Line 241: repoImage.setLastRefreshed(currentTime); Line 242: repoImages.add(repoImage); What should happen if you exceed the totalListSize limit? Line 243: } Line 244: } while((images.getList().size() >= listSize) && repoImages.size() < totalListSize); Line 245: Line 246: return repoImages; -- To view, visit http://gerrit.ovirt.org/19223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b534caccbdcf121b81571384e3420f1a6efde00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches