Moti Asayag has posted comments on this change.
Change subject: core: Vnic hotplug validation - Patch 1 of 2
......................................................................
Patch Set 2:
(1 comment)
A minor comment inside, besides +1
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
Line 81: public HashMap<Pair<Integer, Version>, Boolean>
getNicHotplugSupportMap() {
Line 82:
Line 83: List<Version> versions =
Line 84: new ArrayList<Version>(Config.<HashSet<Version>>
GetValue(ConfigValues.SupportedClusterLevels));
Line 85: HashMap<Pair<Integer, Version>, Boolean>
hotplugSupportOsIdVersionMap =
the type of hotplugSupportOsIdVersionMap can be reduced to Map in this context.
Line 86: new HashMap<Pair<Integer, Version>, Boolean>();
Line 87:
Line 88: for (Integer osId : getOsIds()) {
Line 89: for (Version version : versions) {
--
To view, visit http://gerrit.ovirt.org/19188
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d817323c8b6a7d2ca02c29c200dc4507d6b94c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
