Sergey Gotliv has posted comments on this change. Change subject: core: Vnic hotplug validation - Patch 1 of 2 ......................................................................
Patch Set 4: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java Line 74: public Map<Integer, Map<Version, Boolean>> getSpiceSupportMatrix(); Line 75: Line 76: /** Line 77: * @return if that OS network devices support hotplug. Line 78: */ Why you added @return but ignored @param? Line 79: public boolean hasNicHotplugSupport(int osId, Version version); Line 80: Line 81: /** Line 82: * @return a map that contain an pair (OS id and version) with the hotplug support. -- To view, visit http://gerrit.ovirt.org/19188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d817323c8b6a7d2ca02c29c200dc4507d6b94c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
