Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: do not add default nic on edit vm
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 262: public void onSuccess(Object model, Object result) {
Line 263: initNetworkInterfaces(networkBehavior,
(List<VmNetworkInterface>) result);
Line 264: }
Line 265: };
Line 266: AsyncDataProvider.getVmNicList(getVmNicsQuery, vm.getId());
We can discuss it but I would be careful to do it as a part of this fix. It
would require a bit deeper investigation about how the specific instance of the
VmNetworkInterface is used and if it would not be better to clone the list or
adjust the logic or it is safe to cache it at the beginning. But it is out of
the scope of this patch.
Line 267: }
Line 268:
Line 269: @Override
Line 270: protected void changeDefualtHost()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 1009: AsyncQuery query = new AsyncQuery(this, new
INewAsyncCallback() {
Line 1010:
Line 1011: @Override
Line 1012: public void onSuccess(Object model, Object returnValue) {
Line 1013: doInitNetworkInterfaces(behavior, nics,
(List<VnicProfileView>) returnValue);
Done
Line 1014: }
Line 1015:
Line 1016: });
Line 1017:
--
To view, visit http://gerrit.ovirt.org/17315
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21724b30dc1ad6ccbbe40448ad77c47c22123c06
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
