Omer Frenkel has posted comments on this change.

Change subject: core,ui: VirtIO-SCSI enabled flag
......................................................................


Patch Set 5: Code-Review-1

too bad you only added me as reviewer to this patch and also the previous one, 
which was related to virt as well.
this is not how we handle devices,
iiuc, the way it is now, is that the device is created for each vm run, which 
means new address, and this breaks the stable addresses feature.
if this is true you need to fix this first.

-- 
To view, visit http://gerrit.ovirt.org/18638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice06fda5946b5961cfe9c819b0b368525b1f4b58
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to