Arik Hadas has posted comments on this change.
Change subject: core: add null checks in equal methods
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
Line 58:
DbFacade.getInstance().getDiskDao().getAllForVm(vmId).contains(
Line 59: new Object() {
Line 60: @Override
Line 61: public boolean equals(Object obj) {
Line 62: return obj != null && ((Disk)
obj).isWipeAfterDelete();
it is safe because the List returned by DiskDao#getAllForVm is generic
(List<Disk>) so it is enforced in compilation time that each element in it is
Disk. but if findbugs doesn't know that and still complaining I'll change..
Line 63: }
Line 64: });
Line 65: }
Line 66: return cachedPostZero;
--
To view, visit http://gerrit.ovirt.org/19002
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46d3d4d509e6b1657e4713630a8b218b21f44aa1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
