[Engine-patches] Change in ovirt-engine[master]: core: add null checks in equal methods

[ahadas]

Arik Hadas has uploaded a new change for review.

Change subject: core: add null checks in equal methods
......................................................................

core: add null checks in equal methods

Fix findbugs errors regarding missing null checks in recently added
'equal' methods.

Change-Id: I46d3d4d509e6b1657e4713630a8b218b21f44aa1
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/19002/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
index 4837eb6..8ad6f56 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
@@ -59,7 +59,7 @@
                             new Object() {
                                 @Override
                                 public boolean equals(Object obj) {
-                                    return ((Disk) obj).isWipeAfterDelete();
+                                    return obj != null && ((Disk) 
obj).isWipeAfterDelete();
                                 }
                             });
         }
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
index 465e0ec..f1af60d 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
@@ -44,7 +44,7 @@
                             new Object() {
                                 @Override
                                 public boolean equals(Object obj) {
-                                    return ((Disk) obj).isWipeAfterDelete();
+                                    return obj != null && ((Disk) 
obj).isWipeAfterDelete();
                                 }
                             });
         }


-- 
To view, visit http://gerrit.ovirt.org/19002
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46d3d4d509e6b1657e4713630a8b218b21f44aa1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches