Moti Asayag has posted comments on this change.

Change subject: engine: Added profile logging to VM run/VNIC plug
......................................................................


Patch Set 3: -Code-Review

(1 comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 548:         if (nic.getVnicProfileId() != null) {
Line 549:             vnicProfile = 
DbFacade.getInstance().getVnicProfileDao().get(nic.getVnicProfileId());
Line 550:             if (vnicProfile != null) {
Line 551:                 network = 
DbFacade.getInstance().getNetworkDao().get(vnicProfile.getNetworkId());
Line 552:                 networkName = network == null ? "" : 
network.getName();
note that network == null cannot happen, since we're within a vm which uses 
this vnic profile that has a reference to the network.
Line 553:                 log.debugFormat("VNIC {0} is using profile {1} on 
network {2}",
Line 554:                         nic.getName(), vnicProfile, networkName);
Line 555:                 addQosForDevice(struct, vnicProfile, 
vm.getVdsGroupCompatibilityVersion());
Line 556:             }


-- 
To view, visit http://gerrit.ovirt.org/18967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I483745793213a49fcb0ca1ad0d75ec4faf22f35c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to