Moti Asayag has posted comments on this change.
Change subject: engine: Added profile logging to VM run/VNIC plug
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 558: struct.put(VdsProperties.PORT_MIRRORING, network == null
Line 559: ? Collections.<String> emptyList() :
Collections.singletonList(network.getName()));
Line 560: }
Line 561:
Line 562: log.debugFormat("VNIC {0} is using profile {1} on network
{2}", nic.getName(), vnicProfile, network.getName());
the log is relevant only when the vnic profile is provided. Please print to log
only of vnicProfile != null
This line can be shift to line 551 and will guarantee network isn't null
Line 563: addCustomPropertiesForDevice(struct,
Line 564: vm,
Line 565: vmDevice,
Line 566: vm.getVdsGroupCompatibilityVersion(),
--
To view, visit http://gerrit.ovirt.org/18967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I483745793213a49fcb0ca1ad0d75ec4faf22f35c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
