Daniel Erez has posted comments on this change. Change subject: engine,frontend: disable new vm button if no DC is up ......................................................................
Patch Set 3: Code-Review-1 As described in details under the context of bug 993639 [1], I think we should refrain any queries in syncSearch/updateActionAvailability methods. These methods are invoked every 5 seconds (by default), hence, to prevent additional performance penalty (on client/server), we try to limit the syncSearch to merely retrieve the items (especially on a main-tab...). See discussion in [1]. What do you thing? Any alternative solution instead of graying out the button? E.g. a warning in new VM dialog [1] https://bugzilla.redhat.com/show_bug.cgi?id=993639 -- To view, visit http://gerrit.ovirt.org/18885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id537ac56bd2d963999c5c77ea3e92b3987d82525 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
