Omer Frenkel has posted comments on this change.

Change subject: engine,frontend: disable new vm button if no DC is up
......................................................................


Patch Set 3:

(1 comment)

BE looks ok

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IsSomeStoragePoolUpByClusterServiceQuery.java
Line 5: import org.ovirt.engine.core.common.businessentities.StoragePool;
Line 6: import org.ovirt.engine.core.common.businessentities.StoragePoolStatus;
Line 7: import 
org.ovirt.engine.core.common.queries.GetStoragePoolsByClusterServiceParameters;
Line 8: 
Line 9: public class IsSomeStoragePoolUpByClusterServiceQuery<P extends 
GetStoragePoolsByClusterServiceParameters> extends QueriesCommandBase<P> {
not sure about this, but i this IsAnySto.. sounds better than IsSome
Line 10: 
Line 11:     public IsSomeStoragePoolUpByClusterServiceQuery(P parameters) {
Line 12:         super(parameters);
Line 13:     }


-- 
To view, visit http://gerrit.ovirt.org/18885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id537ac56bd2d963999c5c77ea3e92b3987d82525
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to