Mike Kolesnik has posted comments on this change. Change subject: core: Added get all vith config to SnapshotDao ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/dbscripts/snapshots_sp.sql Line 155: CASE WHEN v_fill_configuration = TRUE THEN vm_configuration ELSE NULL END, Well in this case I'm not sure it matters since there is a vm_configuration IS NOT NULL check before this check, so it should short circuit if it is null on that check and not do the other, meaningless one. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java Line 71: * The VM id. Done .................................................... Commit Message Line 6: Done -- To view, visit http://gerrit.ovirt.org/3035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b5a0d4af2c78805720bf17da5e84fc077e3f22f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
